Specify --prefix for npm install command for typescript and typescript-language-server
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already contains a node_modules folder
|
@microsoft-github-policy-service agree company="Parasail Software, Inc" |
|
LGTM, ty |
|
Was going to open a PR with the exact same change and then I found this! 😄 |
LakshyAAAgrawal
approved these changes
Feb 18, 2025
|
Dear @jetzhou , Thank you so much for catching this and providing a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain setups,
multilspymight be installed at a location where a parent directory has anode_modulesfolder already. For example, in a docker container,multilspywill most likely just be under/usr/local/lib/pythonand if there is anynpminstalled global dependencies, there will also be a/usr/local/lib/node_modulesfolder.In such a setup,
npm install typescriptwill put the executable under/usr/local/lib/node_moduleswhensetup_runtime_dependenciesis run fortypescriptrepos. This will cause the assert for checkingtypescript-language-serverbeing located undermultilspy/language_servers/typescript_language_server/static/ts-lspto fail right after the installation.We can fix this issue by adding
--prefix ./to thenpm installcommand in the settings file. This PR implements that fix.